Reconnexion/ng-eventually
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor(e2e): prendre les types navigateur chez les helpers plutôt que chez playwright

Browse Source
This commit is contained in:
Sylvain Duchesne
2026-08-17 11:12:26 +02:00
parent 935cce4d7b
commit 520c8c59a8
5 changed files with 10 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.project/concepts/e2e-harness/ng-e2e-helpers/usage_polyfill-e2e.md
+2 -2
View File
@@ -1,7 +1,7 @@
---
type: usage
summary: What the polyfill's own end-to-end suites call from ng-e2e-helpers, under which constraints, and where the fit still costs them code
against: ng-e2e-helpers@1.0.0-dev.1
against: ng-e2e-helpers@1.0.0-dev.2
---
# usage_polyfill-e2e — the polyfill's end-to-end suites
@@ -34,7 +34,7 @@ Everything else the package exports is offered and NOT consumed here — the scr
## Constraints
**One Playwright, and the browser types come from the helpers.** These suites import `Frame`, `Page` and `BrowserContext` from `playwright` directly today, which holds only because the package resolves the same copy. The safer form — deriving them from the helpers that return them — is what a consumer in another repository must do, and what this one should adopt.
**The browser types come from the helpers.** `Frame`, `Page` and `BrowserContext` are taken from `ng-e2e-helpers`, which re-exports them, rather than from `playwright` directly — so these suites never depend on resolving the same copy of it, which is the position a consumer in another repository is in anyway.
**Every suite mints its own physical wallet, per run.** Nothing is carried between runs and no wallet is reused, so a run's result never depends on a previous one. The batch wallet's NAME is stable and its identity is not: two runs sharing the name share nothing else.